Skip to content

fix: loosen live collection stack parsing #13988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 2 commits into from
Jun 23, 2025
Merged

fix: loosen live collection stack parsing #13988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83417e3
fix: loosen live collection stack parsing
ascorbic Jun 20, 2025
1a85930
If no matched line, dont bail
ascorbic Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bumpy-experts-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes a bug in live collections that caused it to incorrectly complain about the collection being defined in the wrong file
4 changes: 2 additions & 2 deletions packages/astro/src/content/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function getImporterFilename() {
!line.includes('defineCollection') &&
!line.includes('defineLiveCollection') &&
!line.includes('getImporterFilename') &&
line !== 'Error',
!line.startsWith('Error'),
);
if (!stackLine) {
return undefined;
Expand Down Expand Up @@ -113,7 +113,7 @@ export function defineLiveCollection<
S extends BaseSchema | undefined = undefined,
>(config: LiveCollectionConfig<L, S>): LiveCollectionConfig<L, S> {
const importerFilename = getImporterFilename();
if (!importerFilename?.includes('live.config')) {
if (importerFilename && !importerFilename.includes('live.config')) {
throw new AstroError({
...AstroErrorData.LiveContentConfigError,
message: AstroErrorData.LiveContentConfigError.message(
Expand Down