-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimental responsive images #12377
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5f328e0
chore: changeset
ascorbic 84492b0
feat: add experimental responsive images config option (#12378)
ascorbic ffe063c
Merge branch 'next' into responsive-images
ascorbic e4a9c35
feat: add responsive image component (#12381)
ascorbic 814b873
Merge branch 'next' into responsive-images
ascorbic 46055a6
feat: add crop support to image services (#12414)
ascorbic fd68ea9
Merge branch 'next' into responsive-images
ascorbic b500b10
Merge branch 'next' into responsive-images
ascorbic 582f997
Fix jsdoc
ascorbic f752102
feat: add responsive support to picture component (#12423)
ascorbic d28ba03
Merge branch 'next' into responsive-images
ascorbic a6b283a
docs: add docs for responsive images (#12429)
ascorbic b746c15
Merge branch 'next' into responsive-images
ascorbic 4889154
Add breakpoints option
ascorbic cc1db75
typo
ascorbic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'astro': patch | ||
--- | ||
|
||
Adds experimental reponsive image support |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
[data-astro-image] { | ||
width: 100%; | ||
height: auto; | ||
object-fit: var(--fit); | ||
object-position: var(--pos); | ||
aspect-ratio: var(--w) / var(--h); | ||
} | ||
/* Styles for responsive layout */ | ||
[data-astro-image='responsive'] { | ||
max-width: calc(var(--w) * 1px); | ||
max-height: calc(var(--h) * 1px); | ||
} | ||
/* Styles for fixed layout */ | ||
[data-astro-image='fixed'] { | ||
width: calc(var(--w) * 1px); | ||
height: calc(var(--h) * 1px); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, couldn't the
quality
be different here? Or any other parameters that affects the image, for image services who support more.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this scenario it can't, as this is just checking if it's the srcset entry which is the same as the src. I don't think we expose a way to set this separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't an image service set a different quality for a srcset transform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in theory. I'm comfortable with not supporting that though. It's a terrible idea.