Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show file name with invalid frontmatter errors for MDX #12355

Merged
merged 7 commits into from
Nov 6, 2024
Merged

fix: show file name with invalid frontmatter errors for MDX #12355

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05dd8b5
fix: show file name with invalid frontmatter errors for MDX
apatel369 Nov 2, 2024
0c8e746
Update wise-bulldogs-jump.md
apatel369 Nov 2, 2024
50d177f
Update .changeset/wise-bulldogs-jump.md
apatel369 Nov 2, 2024
c839742
pass location in error
apatel369 Nov 2, 2024
a3c8e20
clean up
apatel369 Nov 4, 2024
44b85e4
Merge branch 'main' into arpan-#12352-file-name
apatel369 Nov 4, 2024
6f93247
feat: rework errors for sync
Princesseuh Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-bulldogs-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Improves error reporting for invalid frontmatter in MDX files during the `astro build` command. The error message now includes the file path where the frontmatter parsing failed.
6 changes: 4 additions & 2 deletions packages/astro/src/core/sync/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
AstroUserError,
createSafeError,
isAstroError,
type ErrorWithMetadata,
} from '../errors/index.js';
import type { Logger } from '../logger/core.js';
import { formatErrorMessage } from '../messages.js';
Expand Down Expand Up @@ -223,7 +224,7 @@ async function syncContentCollections(
}
}
} catch (e) {
const safeError = createSafeError(e);
const safeError = createSafeError(e) as ErrorWithMetadata;
if (isAstroError(e)) {
throw e;
}
Expand All @@ -232,7 +233,8 @@ async function syncContentCollections(
{
...AstroErrorData.GenerateContentTypesError,
hint,
message: AstroErrorData.GenerateContentTypesError.message(safeError.message),
message: AstroErrorData.GenerateContentTypesError.message(`${safeError.message}`),
bluwy marked this conversation as resolved.
Show resolved Hide resolved
location: safeError.loc,
},
{ cause: e },
);
Expand Down
Loading