Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Partytown's Integration does not respect lib option #8760

Closed
1 task
LefanTan opened this issue Oct 5, 2023 · 2 comments
Closed
1 task

BUG: Partytown's Integration does not respect lib option #8760

LefanTan opened this issue Oct 5, 2023 · 2 comments
Labels
- P2: nice to have Not breaking anything but nice to have (priority) help wanted Please help with this issue!

Comments

@LefanTan
Copy link

LefanTan commented Oct 5, 2023

Astro Info

Astro                    v3.0.8
Node                     v18.17.1
System                   macOS (arm64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind
                         @astrojs/vue
                         astro-icon
                         post:build
                         @astrojs/partytown

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

I've noticed that the source code doesn't respect the lib option provided through astro.config.mjs. Our application requires that we host our assets from a different folder path, is it possible for us to override the default config for lib? Much appreciated.

image
image

What's the expected result?

Provide custom lib path to Astro's Partytown integration.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-skk9gg?file=dist%2Ffavicon.svg

Participation

  • I am willing to submit a pull request for this issue.
@LefanTan LefanTan changed the title Partytown's Integration does not respect lib option BUG: Partytown's Integration does not respect lib option Oct 5, 2023
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Oct 5, 2023
@bluwy
Copy link
Member

bluwy commented Oct 9, 2023

I suppose we can have lib take lower precedence here:

...options?.config,
lib,

It doesn't look intentional to me.

@bluwy bluwy added help wanted Please help with this issue! - P2: nice to have Not breaking anything but nice to have (priority) and removed needs triage Issue needs to be triaged labels Oct 9, 2023
@florian-lefebvre
Copy link
Member

I'd like to handle that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) help wanted Please help with this issue!
Projects
None yet
Development

No branches or pull requests

3 participants