Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No assets folder when outDir outside cwd #4825

Closed
1 task
rob-gordon opened this issue Sep 21, 2022 · 3 comments · Fixed by #4841
Closed
1 task

No assets folder when outDir outside cwd #4825

rob-gordon opened this issue Sep 21, 2022 · 3 comments · Fixed by #4841
Labels
- P2: has workaround Bug, but has workaround (priority)

Comments

@rob-gordon
Copy link

What version of astro are you using?

1.2.7

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

I have a pnpm monorepo containing an astro app in one folder and a create-react-app in another.
My goal is to build the create-react-app, then build the astro app into a subfolder of the built create-react-app.

For the most part, this works fine. The only problem is that the public folder isn't copied into the outDir destination, so images and css 404 on the deployed site.

Link to Minimal Reproducible Example

https://github.com/rob-gordon/nested-astro-bug

Participation

  • I am willing to submit a pull request for this issue.
@matthewp matthewp added the - P2: has workaround Bug, but has workaround (priority) label Sep 21, 2022
@rishi-raj-jain
Copy link
Contributor

Taking this up!

matthewp pushed a commit that referenced this issue Sep 22, 2022
* Resolves #4825

* Add changeset

* Update late-cups-jam.md

* Update late-cups-jam.md
@rob-gordon
Copy link
Author

@rishi-raj-jain thanks for the fast fix! 🙏🏻

@rishi-raj-jain
Copy link
Contributor

@rob-gordon My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: has workaround Bug, but has workaround (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants