fix: Can't overwrite vite's MODE environment variable (#4850)

* Add flags to the build options * replace mode: 'production' as fallback * Update mode support * Add changeset
withastro · Sep 23, 2022 · edb7bea · edb7bea
1 parent ee5fdef
commit edb7bea
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/short-ravens-marry.md b/.changeset/short-ravens-marry.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+add support for changing mode via CLI
diff --git a/packages/astro/src/cli/index.ts b/packages/astro/src/cli/index.ts
@@ -239,7 +239,7 @@ async function runCommand(cmd: string, flags: yargs.Arguments) {
 		}
 
 		case 'build': {
-			return await build(settings, { logging, telemetry });
+			return await build(settings, { ...flags, logging, telemetry });
 		}
 
 		case 'check': {

diff --git a/packages/astro/src/core/build/static-build.ts b/packages/astro/src/core/build/static-build.ts
@@ -115,8 +115,8 @@ async function ssrBuild(opts: StaticBuildOptions, internals: BuildInternals, inp
 
 	const viteBuildConfig: ViteConfigWithSSR = {
 		...viteConfig,
+		mode: viteConfig.mode || 'production',
 		logLevel: opts.viteConfig.logLevel ?? 'error',
-		mode: 'production',
 		build: {
 			target: 'esnext',
 			...viteConfig.build,
@@ -193,8 +193,8 @@ async function clientBuild(
 
 	const viteBuildConfig = {
 		...viteConfig,
+		mode: viteConfig.mode || 'production',
 		logLevel: 'info',
-		mode: 'production',
 		build: {
 			target: 'esnext',
 			...viteConfig.build,