Skip to content

Commit

Permalink
create-astro bug fixes (#5319)
Browse files Browse the repository at this point in the history
* fix(create-astro): upgrade cli-kit

* fix(create-astro): avoid setRawMode error

* chore(lint): disable create-astro linting

Co-authored-by: Nate Moore <[email protected]>
  • Loading branch information
natemoo-re and natemoo-re authored Nov 8, 2022
1 parent 982e446 commit b211ead
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/witty-bobcats-eat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-astro': patch
---

Fix bug with `setRawMode`. Respect `--skip-houston` in all cases.
1 change: 1 addition & 0 deletions packages/create-astro/create-astro.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/env node
/* eslint-disable no-console */
'use strict';

const currentVersion = process.versions.node;
Expand Down
2 changes: 1 addition & 1 deletion packages/create-astro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"tsconfigs"
],
"dependencies": {
"@astrojs/cli-kit": "^0.1.3",
"@astrojs/cli-kit": "^0.1.4",
"chalk": "^5.0.1",
"comment-json": "^4.2.3",
"execa": "^6.1.0",
Expand Down
6 changes: 4 additions & 2 deletions packages/create-astro/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export async function main() {
type: 'text',
name: 'directory',
message: 'Where would you like to create your new project?',
initial: `./${generateProjectName()}`,
initial: generateProjectName(),
validate(value) {
if (!isValidProjectDirectory(value)) {
return notEmptyMsg(value);
Expand Down Expand Up @@ -347,7 +347,9 @@ export async function main() {
const devCmd = pkgManager === 'npm' ? 'npm run dev' : `${pkgManager} dev`;
await nextSteps({ projectDir, devCmd });

await say(['Good luck out there, astronaut!']);
if (!args.skipHouston) {
await say(['Good luck out there, astronaut!']);
}
}

function emojiWithFallback(char: string, fallback: string) {
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b211ead

Please sign in to comment.