Re-enable error recovery test (#3396)

* Re-enable error recovery test * Doing some debugging * Remove extra debugging * longer wait * make it wait even longer just to check * Wait a very long time * await the change, and then a little bit * Give a longer timeout for the error recovery test * OK, make it *very* long * Run error tests separately * Get rid of wait
withastro · May 18, 2022 · 6cec1b8 · 6cec1b8
1 parent ef32b7c
commit 6cec1b8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/astro/package.json b/packages/astro/package.json
@@ -71,7 +71,7 @@
     "dev": "astro-scripts dev \"src/**/*.ts\"",
     "postbuild": "astro-scripts copy \"src/**/*.astro\"",
     "benchmark": "node test/benchmark/dev.bench.js && node test/benchmark/build.bench.js",
-    "test": "mocha --exit --timeout 20000 --ignore **/lit-element.test.js && mocha --timeout 20000 **/lit-element.test.js",
+    "test": "mocha --exit --timeout 20000 --ignore **/lit-element.test.js --ignore **/errors.test.js && mocha --timeout 20000 **/lit-element.test.js && mocha --timeout 20000 **/errors.test.js",
     "test:match": "mocha --timeout 20000 -g",
     "test:e2e": "playwright test e2e"
   },

diff --git a/packages/astro/test/errors.test.js b/packages/astro/test/errors.test.js
@@ -5,6 +5,7 @@ import * as cheerio from 'cheerio';
 describe('Error display', () => {
 	if (isWindows) return;
 
+	/** @type {import('./test-utils').Fixture} */
 	let fixture;
 	let devServer;
 
@@ -32,7 +33,7 @@ describe('Error display', () => {
 		});
 	});
 
-	describe('Framework components', () => {
+	describe('Framework components', function() {
 		let devServer;
 
 		before(async () => {
@@ -43,8 +44,7 @@ describe('Error display', () => {
 			await devServer.stop();
 		});
 
-		// Skip until https://github.com/withastro/astro/pull/3376 is revisited
-		it.skip('Errors recover when fixed', async () => {
+		it('Errors recover when fixed', async () => {
 			let html = await fixture.fetch('/svelte-syntax-error').then((res) => res.text());
 
 			// 1. Verify an error message is being shown.

diff --git a/packages/astro/test/test-utils.js b/packages/astro/test/test-utils.js
@@ -33,6 +33,7 @@ polyfill(globalThis, {
  * @property {() => Promise<PreviewServer>} preview
  * @property {() => Promise<void>} clean
  * @property {() => Promise<App>} loadTestAdapterApp
+ * @property {() => Promise<void>} onNextChange
  */
 
 /**