Repository navigation
Upgrade to Astro v7 - #2477
Upgrade to Astro v7#2477
Conversation
- astro 6.4.4 → 7.0.0-beta.5 - @astrojs/mdx 6.0.2 → 7.0.0-beta.3 - @astrojs/netlify 7.0.12 → 8.0.0-beta.1 - Remove experimental.rustCompiler (now default) - Add @astrojs/markdown-remark with unified() processor (MDX files use await in JSX expressions) - Temporarily relax minimumReleaseAge for beta packages
✅ Deploy Preview for astro-www-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }, | ||
| }, | ||
| markdown: { | ||
| processor: unified(), |
There was a problem hiding this comment.
I didn't know about saterri compat and didn't want to deal with it in this PR.
There was a problem hiding this comment.
Looking at the Astro config file, it seems we do not use any remark/rehype plugin, so Sätteri should work (ie. we don't need to port anything but, yeah, we might want to double-check existing blog posts).
There was a problem hiding this comment.
Might as well dogfood I guess, will update.
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I haven't checked the preview yet, so this is more an initial review. One of my comment is more a concern about Astro 7 release than migrating to Astro 7; you might know better how this works.
| }, | ||
| }, | ||
| markdown: { | ||
| processor: unified(), |
There was a problem hiding this comment.
Looking at the Astro config file, it seems we do not use any remark/rehype plugin, so Sätteri should work (ie. we don't need to port anything but, yeah, we might want to double-check existing blog posts).
- Fixes await in MDX JSX expressions - Remove @astrojs/markdown-remark (no longer needed) - Add satteri/@bruits to minimumReleaseAgeExclude
trueberryless
left a comment
trueberryless
left a comment
There was a problem hiding this comment.
Overall looks good to me 7️⃣
I just found a new warning when building locally which is not logged on main:
Removing the invalid :[&:nth-child] part in the class of the links of the sponsors here and here removes the warning (notice that no argument is passed to nth-child, which is why it is invalid). I think this pseudo selector was unintentionally copied from the other lg: breakpoints. All borders are correctly applied even without the pseudo selector.
There was a problem hiding this comment.
Made a couple of tweaks and browsed various pages — everything looks good to me!
Good catch on that selector warning @trueberryless! I think we can fix that in a follow-up PR as it’s not a new issue, just a newly visible warning.
Also noting that curiously the preview deploys are a little slower than main is currently (~1m50s vs ~1m30s comparing last 3 deploys for each). Haven’t investigated why yet — could just be a blip.
4 participants
experimental.rustCompiler(now default)@astrojs/markdown-remarkwithunified()processor (MDX files useawaitin JSX expressions)minimumReleaseAgefor beta packages