Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added windows support for static files #387

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Added windows support for static files #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6c0c28
Added windows support for static files
veitbjarsch Sep 11, 2024
a4329f0
fix: fixed formatting
veitbjarsch Sep 11, 2024
616b23c
fix: fixed linting issue
veitbjarsch Sep 11, 2024
d894e55
adjusted code
veitbjarsch Sep 11, 2024
64e049d
Merge branch 'main' into patch-1
veitbjarsch Sep 11, 2024
dcc23c2
use path.sep instead
veitbjarsch Sep 16, 2024
20e5fe5
Merge branch 'patch-1' of https://github.com/veitbjarsch/adapters int…
veitbjarsch Sep 16, 2024
b6574c8
add changeset
alexanderniebuhr Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/weak-steaks-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/cloudflare': patch
---

Fixes a bug which was caused on windows when splitting static file paths
6 changes: 3 additions & 3 deletions packages/cloudflare/src/utils/generate-routes-json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { AstroConfig, AstroIntegrationLogger, RouteData, RoutePart } from '

import { existsSync } from 'node:fs';
import { writeFile } from 'node:fs/promises';
import { posix } from 'node:path';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import {
prependForwardSlash,
Expand Down Expand Up @@ -186,7 +186,7 @@ export async function createRoutesFile(
const staticPath = staticFile;

const segments = removeLeadingForwardSlash(staticPath)
.split(posix.sep)
.split(path.sep)
.filter(Boolean)
.map((s: string) => {
return getParts(s);
Expand Down Expand Up @@ -232,7 +232,7 @@ export async function createRoutesFile(
for (const page of pages) {
if (page.pathname === '404') hasPrerendered404 = true;
const pageSegments = removeLeadingForwardSlash(page.pathname)
.split(posix.sep)
.split(path.posix.sep)
.filter(Boolean)
.map((s) => {
return getParts(s);
Expand Down