Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(next): astro:env cleanup #385

Merged
merged 3 commits into from
Sep 12, 2024
Merged

chore(next): astro:env cleanup #385

merged 3 commits into from
Sep 12, 2024

Conversation

florian-lefebvre
Copy link
Member

Changes

  • Cleans some forgotten workarounds for astro:env

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 69be484

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 42 packages
Name Type
@astrojs/netlify Minor
@astrojs/vercel Minor
@astrojs/node Minor
@test/netlify-cookies Patch
@test/netlify-middleware-without-handler-file Patch
@test/netlify-redirects Patch
@test/netlify-hosted-astro-project Patch
@test/netlify-static-redirects Patch
@test/astro-vercel-basic Patch
@test/astro-vercel-image Patch
@test/vercel-isr Patch
@test/vercel-max-duration Patch
@test/vercel-edge-middleware-with-edge-file Patch
@test/vercel-edge-middleware-without-edge-file Patch
@test/astro-vercel-no-output Patch
@test/astro-vercel-prerendered-error-pages Patch
@test/astro-vercel-redirects-serverless Patch
@test/astro-vercel-redirects Patch
@test/vercel-server-islands Patch
@test/astro-vercel-serverless-prerender Patch
@test/astro-vercel-serverless-with-dynamic-routes Patch
@test/astro-vercel-static-assets Patch
@test/astro-vercel-static Patch
@test/vercel-streaming Patch
@test/astro-vercel-with-speed-insights-enabled-output-as-server Patch
@test/astro-vercel-with-speed-insights-enabled-output-as-static Patch
@test/astro-vercel-with-web-analytics-enabled-output-as-static Patch
vercel-hosted-astro-project Patch
@test/nodejs-api-route Patch
@test/nodejs-badurls Patch
@test/nodejs-encoded Patch
@test/nodejs-errors Patch
@test/nodejs-headers Patch
@test/nodejs-image Patch
@test/locals Patch
@test/node-middleware Patch
@test/nodejs-prerender-404-500 Patch
@test/nodejs-prerender Patch
@test/nodejs-preview-headers Patch
@test/node-trailingslash Patch
@test/url Patch
@test/well-known-locations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@florian-lefebvre
Copy link
Member Author

The error looks unrelated

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the polyfills are applied before astro/env/setup is loaded.

packages/netlify/src/ssr-function.ts Show resolved Hide resolved
@florian-lefebvre florian-lefebvre merged commit bb725b7 into next Sep 12, 2024
8 checks passed
@florian-lefebvre florian-lefebvre deleted the florian/next-env branch September 12, 2024 15:35
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
This was referenced Sep 23, 2024
This was referenced Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants