Set the workspace root when doing nft scan #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0fb6bb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
|
!preview netlify-bug |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
matthewp
changed the title
|
Tried the snapshot version and I can confirm it is working: 
|
ascorbic
reviewed
Sep 9, 2024
| import type { AstroIntegrationLogger } from 'astro'; | ||
| import { searchForWorkspaceRoot } from 'vite'; |
bluwy
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Why do we have copied the function for vercel but not for netlify?
There was a problem hiding this comment.
For some reason simply having a import 'vite' in the Vercel adapter causes tests to timeout. I spent too much time and couldn't figure out why.
There was a problem hiding this comment.
We could move it into our shared utils, like we already did with some other vite stuff
alexanderniebuhr
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/folder, which causes chaos if you have routes like/homeor/dev. This fixes it by setting it to the workspace root instead.