-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vercel,netlify): Prevent NFT from scanning users directory #379
Conversation
🦋 Changeset detectedLatest commit: 303d78c The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shouldn't have any side-effects
Have another PR #381 which I think fixes this in a better way, but making the base be the workspace root. |
Let’s do it! |
Closing this in favor of #381 |
Still thank you for the contribution. We appreciate it a lot. Hope to see you around the repository in the future :) |
Changes
This PR adds
/users/**
to ignored directories being scanned by@vercel/nft
. This happens when:/users
string somewhere in your codebase and your app is located in/Users/**
directorypnpm
and the package/module that has that/users
string is not added tonode_modules
because ofpnpm
symlinks@vercel/nft
thinks the/users
string is a directory and scans itHere's a complete convo from discord - https://discord.com/channels/830184174198718474/1281031671495397437
Testing
I tested it locally via
pnpm patch
, and runpnpm build
. It works:Docs