fix(netlify): only cache GET/HEAD methods (#127)

Co-authored-by: Sarah Rainsberger <[email protected]>
withastro · Jan 11, 2024 · 36434f0 · 36434f0
1 parent 09306d5
commit 36434f0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/dry-rules-bathe.md b/.changeset/dry-rules-bathe.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/netlify': patch
+---
+
+Updates the behavior of the `cacheOnDemandPages` setting to only cache GET/HEAD requests by default
diff --git a/packages/netlify/src/ssr-function.ts b/packages/netlify/src/ssr-function.ts
@@ -36,14 +36,16 @@ export const createExports = (manifest: SSRManifest, _args: Args) => {
 			}
 
 			if (integrationConfig.cacheOnDemandPages) {
+				const isCacheableMethod = ['GET', 'HEAD'].includes(request.method);
+
 				// any user-provided Cache-Control headers take precedence
 				const hasCacheControl = [
 					'Cache-Control',
 					'CDN-Cache-Control',
 					'Netlify-CDN-Cache-Control',
 				].some((header) => response.headers.has(header));
 
-				if (!hasCacheControl) {
+				if (isCacheableMethod && !hasCacheControl) {
 					// caches this page for up to a year
 					response.headers.append('CDN-Cache-Control', 'public, max-age=31536000, must-revalidate');
 				}