fix(cloudflare): using vue breaks builds (#210)

Co-authored-by: Emanuele Stoppa <[email protected]>

.changeset/shy-cooks-knock.md

@@ -0,0 +1,5 @@
+---
+'@astrojs/cloudflare': patch
+---
+
+fixes an issue where projects using `@astrojs/vue` were unusable, due to marking dependencies as external

packages/cloudflare/package.json

@@ -34,7 +34,7 @@
     "miniflare": "^3.20240320.0",
     "esbuild": "^0.19.5",
     "tiny-glob": "^0.2.9",
-    "wrangler": "^3.36.0"
+    "wrangler": "^3.39.0"
   },
   "peerDependencies": {
     "astro": "^4.2.0"

packages/cloudflare/src/index.ts

@@ -173,7 +173,18 @@ export default function createIntegration(args?: Options): AstroIntegration {
 					vite.ssr ||= {};
 					vite.ssr.target = 'webworker';
 					vite.ssr.noExternal = true;
-					vite.ssr.external = _config.vite.ssr?.external ?? [];
+
+					if (typeof _config.vite.ssr?.external === 'undefined') vite.ssr.external = [];
+					if (typeof _config.vite.ssr?.external === 'boolean')
+						vite.ssr.external = _config.vite.ssr?.external;
+					if (Array.isArray(_config.vite.ssr?.external))
+						// `@astrojs/vue` sets `@vue/server-renderer` to external
+						// https://github.com/withastro/astro/blob/e648c5575a8774af739231cfa9fc27a32086aa5f/packages/integrations/vue/src/index.ts#L119
+						// the cloudflare adapter needs to get all dependencies inlined, we use `noExternal` for that, but any `external` config overrides that
+						// therefore we need to remove `@vue/server-renderer` from the external config again
+						vite.ssr.external = _config.vite.ssr?.external.filter(
+							(entry) => entry !== '@vue/server-renderer'
+						);
 
 					vite.build ||= {};
 					vite.build.rollupOptions ||= {};