New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use URI.encode_www_form_component instead of URI.escape #65

Merged

chen-anders merged 1 commit into wistia:master from leklund:remove_uri_escape

Nov 27, 2023

Contributor

leklund commented Oct 26, 2021

URI.escape has been deprecated and obsolete for many years. Ruby 2.7 emits a warning:

nsq-ruby-2.3.1/lib/nsq/discovery.rb:73: warning: URI.escape is obsolete

Using URI.encode_www_form_component will properly encode the topic for the lookup query.


          use URI.encode_www_form_component instead of URI.escape (obsolete)

78779b3

annawinkler commented Oct 26, 2021

I would love to see this merged and a new release pushed! The warnings in the console are super annoying.

chen-anders merged commit 6a2fe56 into wistia:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet