chore: Don't set constants in theme.py

wireservice · Oct 23, 2023 · 8252e56 · 8252e56
1 parent c5443d8
commit 8252e56
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/docs/examples.rst b/docs/examples.rst
@@ -193,9 +193,9 @@ Style attributes of individual data points can be set by value using a :func:`.s
 .. figure:: ../examples/charts/colorized_dots.svg
 
 Creating dashed lines
-----------------------------
+---------------------
 
-When adding a line using :meth:`.Chart.add_line` you can set the `stroke_dasharray` property.  More details on the property `here <https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray>`_.
+When using :meth:`.Chart.add_line`, you can set the `stroke_dasharray property <https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray>`_.
 
 .. literalinclude:: ../examples/lines_dashes.py
     :language: python

diff --git a/leather/shapes/line.py b/leather/shapes/line.py
@@ -42,7 +42,7 @@ def _new_path(self, stroke_color):
             fill='none'
         )
         path.set('stroke-width', str(self._width))
-        if self._stroke_dasharray != theme.STROKE_DASHARRAY_NONE:
+        if self._stroke_dasharray != 'none':
             path.set('stroke-dasharray', self._stroke_dasharray)
 
         return path

diff --git a/leather/theme.py b/leather/theme.py
@@ -126,5 +126,4 @@
 default_line_width = 2
 
 #: Default stroke-dasharray property when using dashes on a line
-STROKE_DASHARRAY_NONE = 'none'
-default_stroke_dasharray = STROKE_DASHARRAY_NONE
+default_stroke_dasharray = 'none'