Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a fast way to normalize/standardize/slugify column names #466

Closed
onyxfish opened this issue Feb 5, 2016 · 5 comments
Closed

Need a fast way to normalize/standardize/slugify column names #466

onyxfish opened this issue Feb 5, 2016 · 5 comments
Labels

Comments

@onyxfish
Copy link
Collaborator

onyxfish commented Feb 5, 2016

See wireservice/csvkit#396

@onyxfish
Copy link
Collaborator Author

onyxfish commented Feb 5, 2016

We should pull a known good slugifier into utils, such as the one used in Django. Then this could be a flag to the constructor or a method similar to rename. (I'm debating which I prefer.)

@onyxfish
Copy link
Collaborator Author

onyxfish commented Feb 5, 2016

@onyxfish
Copy link
Collaborator Author

onyxfish commented Feb 5, 2016

Could also lead to a Slugify(columns) computation, which would be handy.

@onyxfish
Copy link
Collaborator Author

onyxfish commented Feb 5, 2016

Note, that slugger doesn't handle uniqueness, but this one does: https://github.com/dimka665/awesome-slugify

@nbedi nbedi closed this as completed in e014053 May 23, 2016
@nbedi
Copy link
Member

nbedi commented May 23, 2016

@onyxfish added slugify into utils. It wraps around https://github.com/dimka665/awesome-slugify.

A flag to the constructor and a whole new method felt off to me. Ended up adding it as an option to Table.rename since it feels like an advanced functionality of renaming and had the best of both. Let me know what you think and if I should adjust.

nbedi added a commit that referenced this issue May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants