Remove IsValid Check on DHDD Data Input #2736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When setting the DHDD Data input to an array using wires, the Memory output is changed accordingly. However, when using wirelinks to set Data, there appears to be no effect.
This PR allows wirelinks to properly set the Data input of DHDDs. The default behavior of DHDDs can still be expected as an input trigger with nil is already accounted for.
Issue
To Reproduce:
Create two DHDDs.
Create an E2 that outputs an array such as
Out = array(...)
and wire it to one DHDD.Observe the memory of the DHDD with the debugger. It will contain all the data you pass to it.
Create another E2 that uses wirelinks such as
DHDD["Data", array] = ...
to set Data on the DHDD.Observe the memory of the DHDD. It will contain nothing.
Expected behavior:
Setting Data through wirelink should update the DHDD appropriately.