Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IsValid Check on DHDD Data Input #2736

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

Denneisk
Copy link
Member

Description:
When setting the DHDD Data input to an array using wires, the Memory output is changed accordingly. However, when using wirelinks to set Data, there appears to be no effect.

This PR allows wirelinks to properly set the Data input of DHDDs. The default behavior of DHDDs can still be expected as an input trigger with nil is already accounted for.

Issue

To Reproduce:

  1. Create two DHDDs.

  2. Create an E2 that outputs an array such as Out = array(...) and wire it to one DHDD.

  3. Observe the memory of the DHDD with the debugger. It will contain all the data you pass to it.
    image

  4. Create another E2 that uses wirelinks such as DHDD["Data", array] = ... to set Data on the DHDD.

  5. Observe the memory of the DHDD. It will contain nothing.
    image

Expected behavior:
Setting Data through wirelink should update the DHDD appropriately.

@thegrb93 thegrb93 merged commit 3e308e3 into wiremod:master Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants