Text Entry patch

[stepa2]

• Added 'Entered' output that indicates that player just entered the text
• Disabled background blur in UI

[Divran]

Why is this needed, the text output is triggered, is that not enough?

[thegrb93]

Why is this needed, the text output is triggered, is that not enough?

I think entering the same text value would cause it not to trigger. Also is useful to have a normal output for indicating that it was triggered. Not sure what string gate you would use to convert to normal for that.

[thegrb93]

Please get rid of the 'hold' code. Especially for the fact that it allows a timer to exist forever.

[thegrb93]

@stepa2

[stepa2]

Do you want me to remove it completely? It will break dupe compatibility.
I can add upper limit for hold time.

[thegrb93]

Any dupes with hold will just have the hold var ignored. Should leave it in the dupe args though so future code doesn't get incompatible.

[stepa2]

Some dupes may stop working without hold.
Either ones that rely on text cleaned after specified time to simulate Entered output by, e.g., ~Text & Text E2 check,
or ones that rely on text being held for specified time to simulate Entered in another way like

if(~Use & Use) { timer("check_it",10) }
if(clk("check_it")) {
    useTextInSomeWay(Text)
}

[thegrb93]

I guess it is a small behavior change of text screen. I'm ok with it

[stepa2]

Text holding behavior can be used (was used by me, for example) as an alternative way to activate E2 on text change.
So removing it will break E2s too

[thegrb93]

Your e2 will still be activated by the Entered output, it will just happen on and off on the same frame. I don't know how that would break your use case.

[stepa2]

I added Entered input in this PR, there was no such output before.

[thegrb93]

Ok, fine then. We need to add timer.Remove to the SENT's OnRemove function then. That's the last thing it needs.

[stepa2]

Can this PR be merged now?