Validate I/O in case addons pass incorrect values #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
reviewed
Aug 10, 2023
lua/wire/server/wirelib.lua
Outdated
| local ty = WireLib.DT[output.Type] | ||
| if ty and not ty.Validator(value) then | ||
| -- Not copying here is fine since data types are immutable outside E2. | ||
| value = ty.Zero |
There was a problem hiding this comment.
Should return a copy of 'Zero'. Maybe change 'ty.Zero' into a function that returns a new zero so this line becomes value = ty.Zero()
There was a problem hiding this comment.
I'm not sure how ports handle mutable types, so maybe I'm wrong.
There was a problem hiding this comment.
Wire just doesn't mutate any data types, and E2 table.Copys the types before using them and outputting them.
But since this is a PR to fix addon creators potentially messing stuff up, might as well do this too in case they mutate the default value.
thegrb93
approved these changes
Aug 11, 2023
|
Um, one other issue is this is going to fuck performance in x64 gmod. Facepunch/garrysmod-issues#4100 |
|
I mean, this is serverside, I doubt many servers are hosted on 64 bit |
|
Yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to wiremod as a whole, now inputs and outputs will be validated to ensure correctness on TriggerInput/TriggerOutput (E2 wirelinks use this as well).
In this case the value will be replaced with the default value for the type.