Miscellaneous E2 player additions #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add e:userID() Add player(n) Add teamMembers(n) and teamMemberCount(n) (deprecate teamPlayers) Minor cleanup
Clean entity:inVehicle()
|
Don't leave commented code; just delete it |
|
Think of all the keystrokes that guy in 15 years will save. |
thegrb93
reviewed
Aug 9, 2023
| @@ -85,7 +75,25 @@ e2function string entity:steamID64() | |||
| if not IsValid(this) then return self:throw("Invalid entity!", "") end | |||
| if not this:IsPlayer() then return self:throw("Expected a Player but got an Entity!", "") end | |||
|
|
|||
| return this:SteamID64() or "" | |||
| return this:SteamID64() | |||
There was a problem hiding this comment.
I vaguely remember this returning nil if the the player is a bot. Might need the or "". Could be wrong though
There was a problem hiding this comment.
The rest of the changes look fine
There was a problem hiding this comment.
Latest update said it now always returns something valid.
Made Player:SteamID64 and Player:AccountID never return no value
There was a problem hiding this comment.
no value is not the same as nil, although it looks like they did also change the nil case. I think the only case where this happened was when a player signed in on a -multirun client.
thegrb93
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
number entity:accountID()- returns the player's account ID.number entity:userID()- returns the player's user ID. This is different from entity index.entity player(index)- returns a player entity from the user ID.array teamMembers(index)- returns an array with the members of a team.number teamMemberCount(index)- returns the number of players on a team.Changes:
number teamPlayers(index)(misleading, should be replaced byteamMembers)Removals:
Player.LocalEyeAngles()existingTest code
Fixes #2660