Clean up interpolation functions #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
reviewed
Aug 9, 2023
|
|
||
| for i = 0,30 do | ||
| if bit.band(n, (2^i)) ~= 0 then | ||
| if bit.band(n, 2 ^ i) ~= 0 then |
There was a problem hiding this comment.
2^i should be bit.lshift(1,i)
|
Would you mind if I also converted some of the vector functions to use the Gmod functions instead while I'm at it? I found it marginally better while benchmarking. |
|
Do a new PR for those |
thegrb93
approved these changes
Aug 10, 2023
|
oops, accidentally caused merge conflict with fixing lints on the print pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up interpolation functions, minor optimizations, and adds one new function (
bezier(vvvn)) taking advantage of newly released bezier functions.This PR should be delayed until widespread adoption of the latest Gmod update has occurred.
Would like to mention #2716 as I had intended to add a replacement function
lerp(...)but wasn't sure if I should just replace the originalmixto the peril of any previous users.Test code