-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-28: add support for multiple property injection #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some polishing, but seems I can't push to your branch, so take a look at this commit: 4a85af0
Unless there's something that i've missed, feel free to cherry-pick it and update your branch.
Also please update a readme, like a line or two that you can also set multiple properties and why would you want to do that.
Once its there, I'll merge and trigger a new release.
Thanks for contribution!
Hi @maciejwalkowiak , I added some hints about the multiple property injection feature. Please have look at the
Greetings PS: I am not used to work with forks. I created another PR for updating the |
*/ | ||
String property() default ""; | ||
String[] property() default ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current implementation is fully backward compatible.
But its readability is not as good as it could be when renaming the attribute to properties
, is it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Add properties
and mark property
as deprecated. For the time being we will support both, later the property
will be removed.
…EADME.md) (wiremock#31) * wiremockGH-28: add support for multiple property injection * wiremockGH-28: add support for multiple property injection
Thanks @rfelgent! Thanks for updating readme, don't worry it is in another branch, i'll put it into |
Hi @maciejwalkowiak , I renamed/refactored the attributes |
Hi @maciejwalkowiak , please let me know what else I can do for this merge request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for late reply. Thanks again for a PR!
hi @maciejwalkowiak ,
here is the pull request for #28.
Please let me know what else I can do for this pull request to be accepted.