Skip to content

Conversation

@StefH
Copy link
Collaborator

@StefH StefH commented Sep 28, 2025

No description provided.

@StefH StefH self-assigned this Sep 28, 2025
@StefH StefH added the feature label Sep 28, 2025
@StefH StefH requested a review from Copilot September 28, 2025 08:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the ProxyUrlTransformer class to centralize URL transformation logic for proxy operations, supporting both simple string replacement and template-based transformations using Handlebars or Scriban.

Key changes:

  • Added new ProxyUrlTransformer class with support for template-based URL transformations
  • Enhanced ProxyUrlReplaceSettings with transformer capabilities including UseTransformer property and template support
  • Refactored existing transformer creation logic into a centralized TransformerFactory

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ProxyUrlTransformerTests.cs Comprehensive test coverage for the new proxy URL transformation functionality
ProxyUrlReplaceSettings.cs Enhanced settings class with transformer template support and nullable annotations
TransformerFactory.cs New factory class to centralize transformer instantiation logic
Transformer.cs Added new Transform method overload for simple template/model transformations
ITransformerContextFactory.cs Updated interface visibility and formatting
ITransformer.cs Added new Transform method signature and updated visibility
Response.cs Refactored to use the new TransformerFactory instead of inline transformer creation
ProxyUrlTransformer.cs New core class implementing URL transformation logic
ProxyHelper.cs Refactored to use ProxyUrlTransformer and updated to primary constructor syntax
WebhookSender.cs Refactored to use TransformerFactory and updated to primary constructor syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.70%. Comparing base (371bfdc) to head (cd4d3c6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../WireMock.Net.Minimal/Proxy/ProxyUrlTransformer.cs 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
+ Coverage   35.61%   35.70%   +0.08%     
==========================================
  Files         150      152       +2     
  Lines       34554    34537      -17     
==========================================
+ Hits        12308    12332      +24     
+ Misses      21841    21780      -61     
- Partials      405      425      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefH StefH merged commit 19e9532 into master Sep 28, 2025
11 checks passed
@StefH StefH deleted the stef-ProxyUrlTransformer branch September 28, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants