-
Notifications
You must be signed in to change notification settings - Fork 297
feat: oauth landing page [SQSERVICES-1775] #14793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
cd1701a
feat: basic UI structure
tlebon da4d9c7
chore: add some validation for the params
tlebon 7b3e1c2
chore: remove errors
tlebon 6c667af
chore: more structure added
tlebon 02e54a2
chore: update redux to add getTeam action
tlebon 419021c
fix: get redux working correctly with auth
tlebon 6baeb80
feat: improve routing
tlebon d4a84ac
feat: display team image, improved styling
tlebon eed53b8
chore: get application name from BE
tlebon a492a6f
chore: add oauth calls
tlebon f9579ae
chore: merge dev
tlebon 728ed3e
chore: update api client
tlebon 5176729
chore: add redirect for 2manyClients case
tlebon b245105
chore: update copy for 2manyclients case
tlebon 0276e94
chore: add back initial redirect
tlebon 08c7899
feat: pass redirect url
tlebon 0f4fc94
chore: fix scope parsing
tlebon de0172c
chore: update for loading icon
tlebon 67cf9f1
chore: remove client device name
tlebon e4067de
runfix: issue with missing team icon
tlebon 3f0bd47
runfix: issue with client page
tlebon b9de86c
feat: improve styling
tlebon fe862aa
chore: styling
tlebon 7773e81
chore: merge dev
tlebon 9cbcf6d
chore: add translations
tlebon 5291e2a
chore: update core
tlebon cd585b0
chore: resolve comments
tlebon cdabad4
chore: merge dev
tlebon a8b48c4
fix: other instances of formatted message cleanup
tlebon b8a7c5b
chore: move styles to individual file
tlebon dee8034
styles: fixing styling issues
tlebon 550279e
chore: merge dev
tlebon 20c19a8
chore: switch to URLSearchParams
tlebon 0b1d886
chore: handle logout for error cases
tlebon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,7 +78,7 @@ export class ClientAction { | |
| }; | ||
| }; | ||
|
|
||
| generateClientPayload = (clientType: ClientType): ClientInfo | undefined => { | ||
| private generateClientPayload = (clientType: ClientType): ClientInfo | undefined => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 🙏 |
||
| if (clientType === ClientType.NONE) { | ||
| return undefined; | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was this one for 🤔 ?
Good that we could get rid of it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no clue, i guess our linter changed a while ago. maybe we turned off this rule where components need to be named?