Skip to content

Comments

Issue 625#86

Merged
tiago-loureiro merged 3 commits intodevelopfrom
issue-625
Oct 10, 2017
Merged

Issue 625#86
tiago-loureiro merged 3 commits intodevelopfrom
issue-625

Conversation

@tiago-loureiro
Copy link
Contributor

Return proper error response in case a team has reached its size limit and a user tries to join. We check this in 2 places because:

  • We want to fail as early as possible and avoid adding users to the user table that will not be able to verify their account.
  • There is always a potential race condition when 2 users register so we must assume that addTeamMember can potentially fail.

@tiago-loureiro tiago-loureiro merged commit beb183c into develop Oct 10, 2017
@tiago-loureiro tiago-loureiro deleted the issue-625 branch October 10, 2017 15:51
smatting pushed a commit that referenced this pull request Apr 20, 2022
Also fixes #83 (duplicate label)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants