Activate team on account activation only#85
Merged
Conversation
Contributor
There was a problem hiding this comment.
This could be shortened to: getBindingTeamId zusr = withBindingTeam zusr $ pure . json
services/brig/src/Brig/API/User.hs
Outdated
Contributor
There was a problem hiding this comment.
How about:
for_ tid $ (`Intra.changeTeamStatus` Team.Active)
or
for_ tid $ flip Intra.changeTeamStatus Team.Active
Contributor
There was a problem hiding this comment.
How about using PendingActive to give a bit more info similarly to what we do with PendingDelete ?
tiago-loureiro
suggested changes
Oct 9, 2017
Contributor
tiago-loureiro
left a comment
tiago-loureiro
left a comment
There was a problem hiding this comment.
Besides the small nitpicks, 
jschaul
force-pushed
the
feature/pending-teams
branch
from
78a36f9 to
748fb75
Compare
Member
Author
|
Thanks for the review, I implemented your suggestions. |
Add Pending state to Teams, which is their initial state. Upon the first user account activation, teams also become active.
jschaul
force-pushed
the
feature/pending-teams
branch
from
748fb75 to
b11cdf0
Compare
tiago-loureiro
approved these changes
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Pendingstate to Teams, which is their initial state. Upon the first user account activation, an associated team also becomes active.