ClientAPI: Include unnesting of capabilties in V7, ensure consumable notifs are not part of the enum#4366
Merged
akshaymankar merged 10 commits intodevelopfrom Dec 11, 2024
Merged
Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
fix-v7-client-caps
branch
from
a0d0553 to
68071d7
Compare
akshaymankar
force-pushed
the
fix-v7-client-caps
branch
from
68071d7 to
ea64731
Compare
fisx
reviewed
Dec 10, 2024
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
it all looks pretty reasonable to me except for the swagger output. hm...
akshaymankar
commented
Dec 11, 2024
fisx
force-pushed
the
fix-v7-client-caps
branch
from
4e5b3a2 to
4432e83
Compare
Because events are not supposed to break API
fisx
approved these changes
Dec 11, 2024
echoes-hq
bot
added
the
echoes: product-roadmap/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was because v6 swagger was committed as v7 by mistake.
Checklist
changelog.d