[WPB-10324] Drop legacy notification endpoints#4363
[WPB-10324] Drop legacy notification endpoints#4363mdimjasevic wants to merge 3 commits intodevelopfrom
Conversation
7e25bfd to
f186632
Compare
changelog.d/1-api-changes/WPB-10324
Outdated
There was a problem hiding this comment.
did you also create the confluence page and add it there? seems like a good idea to me, especially since we might all completely forget by the time this becomes relevant.
There was a problem hiding this comment.
I haven't yet, as I am still not 100% sure what version this should be reflected in. The latest discussion in the ticket suggests this won't be done in version 9, but in a much later version and perhaps this PR can be closed, but let's wait and see how the discussion evolves.
integration/test/Test/Version.hs
Outdated
There was a problem hiding this comment.
| -- it is however theoretically possible to have a different number of | |
| -- it is however theoretically (and practically) possible to have a different number of |
There was a problem hiding this comment.
this will conflict with #4356
but maybe that's fine?
There was a problem hiding this comment.
Yes, that's totally fine. I am aware of this. There's no way to avoid conflicts if we work in parallel on related stuff. I see the PR has been merged in the PR so I'll rebase this PR to resolve the conflicts.
a25f9eb to
103e36b
Compare
103e36b to
1158d2e
Compare
akshaymankar
left a comment
There was a problem hiding this comment.
Let's merge it when the work for clients is scheduled, so we avoid creating chores to keep updating this version number.
Tracked by https://wearezeta.atlassian.net/browse/WPB-10324.
Checklist
changelog.d