Log uncaught IO exceptions in cargohold#4352
Merged
pcapriotti merged 2 commits intodevelopfrom Nov 29, 2024
Merged
Conversation
echoes-hq
bot
added
the
echoes: unplanned/incident
stefanwire
approved these changes
Nov 29, 2024
zebot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncaught IO exceptions in cargohold simply become "Server Error" responses with no extra information. This PR ensures that such exceptions are logged before being handled by the middleware, just like it happens in galley.
https://wearezeta.atlassian.net/browse/WPB-14410
Checklist
changelog.d