Skip to content

brig: make rabbitmq field optional again#4340

Merged
elland merged 4 commits intodevelopfrom
brig-rabbitmq
Nov 14, 2024
Merged

brig: make rabbitmq field optional again#4340
elland merged 4 commits intodevelopfrom
brig-rabbitmq

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Nov 13, 2024

It seems the rabbitmq configuration field in brig was made mandatory by mistake in #4272. This reverts it to an optional field and removes the corresponding Input effect, which was unused.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 13, 2024
@pcapriotti pcapriotti marked this pull request as ready for review November 13, 2024 16:04
@elland elland merged commit b987991 into develop Nov 14, 2024
@elland elland deleted the brig-rabbitmq branch November 14, 2024 09:16
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants