[WPB-8881] Add unit tests for new effect actions

[mdimjasevic]

This is a follow-up PR to #4316 that adds unit tests for effect actions that were introduced in that PR.

Tracked by https://wearezeta.atlassian.net/browse/WPB-8881

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[mdimjasevic]

@supersven , is there anything else you'd like me to change, update, or do about it?

[supersven]

Have you considered to add a test where the lookup fails? E.g. there is a code, but the key does not match?

[mdimjasevic]

Just added it! I've rebased and pushed.

[supersven]

Cool, thanks! (The more test code coverage we can add, the better - as long as the task doesn't grow out of bounds, of course 😄 )

[supersven]

I'm wondering if it wouldn't be useful to also test what happens when the user does not exist. Or, can't this case not happen? 🤔

[mdimjasevic]

Yeah, that can happen. I'd argue it's out of scope for this ticket. Lots of stuff hasn't been tested, and I've added tests for the actions that I introduced in that original PR. Looking up a user in the storage is not an action that was in that PR.

[supersven]

Ah, I see. Then, I'm approving. 👍