Skip to content

Add a few more swagger descriptions and examples.#4323

Merged
fisx merged 4 commits intodevelopfrom
fisx/fix-swagger-2024-10-31
Nov 4, 2024
Merged

Add a few more swagger descriptions and examples.#4323
fisx merged 4 commits intodevelopfrom
fisx/fix-swagger-2024-10-31

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 31, 2024

2024-10-31-134844_1600x900_scrot
2024-10-31-134825_1600x900_scrot
2024-10-31-134816_1600x900_scrot

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 31, 2024
@mastaab
Copy link
Contributor

mastaab commented Oct 31, 2024

can you maybe also add a description for "currency" while you are at it?

@netbe
Copy link

netbe commented Oct 31, 2024

out of curiousity, where does the retention_information link go to ? @fisx

@fisx
Copy link
Contributor Author

fisx commented Oct 31, 2024

out of curiousity, where does the retention_information link go to ? @fisx

the code that parses asset ids :-)

but as @akshaymankar says, it's probably better to take that out again.

@fisx fisx force-pushed the fisx/fix-swagger-2024-10-31 branch from 9de2ae5 to 41fdd74 Compare October 31, 2024 21:30
@fisx
Copy link
Contributor Author

fisx commented Nov 1, 2024

@fisx fisx requested a review from akshaymankar November 1, 2024 14:37
@fisx fisx removed the request for review from akshaymankar November 4, 2024 13:21
@fisx fisx merged commit d6eade4 into develop Nov 4, 2024
@fisx fisx deleted the fisx/fix-swagger-2024-10-31 branch November 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants