Skip to content

Fix swagger#4309

Merged
fisx merged 4 commits intodevelopfrom
fisx/fix-swagger
Oct 25, 2024
Merged

Fix swagger#4309
fisx merged 4 commits intodevelopfrom
fisx/fix-swagger

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 25, 2024

dc889c0305eac14fd42a1b1ddd163fcf26271e54 is the interesting commit in this PR. Tested this with and without the patch on a blocked version, and the fix does the right thing.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx requested a review from battermann October 25, 2024 09:01
@fisx fisx added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 25, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 25, 2024
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so the specialisation type family was duplicated? Probably my mistake, sorry.

@fisx fisx force-pushed the fisx/fix-swagger branch from fd62280 to 12fd920 Compare October 25, 2024 13:58
@fisx fisx merged commit 6f77039 into develop Oct 25, 2024
@fisx fisx deleted the fisx/fix-swagger branch October 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants