WPB-685 give SCIM connections human readable names#4307
Merged
battermann merged 21 commits intodevelopfrom Oct 25, 2024
Merged
Conversation
93fbd76 to
e643594
Compare
fisx
approved these changes
Oct 24, 2024
Contributor
fisx
left a comment
There was a problem hiding this comment.
LGTM. Now we should do the same thing for saml idps, and then support multiple idps and multiple scim tokens in one team, and connecting them to each other. there should be tickets for that, too, right?
| @@ -0,0 +1 @@ | |||
| New variant in API version 7 of endpoints for creating and listing SCIM tokens that support a `name` field. New endpoint in version 7 for updating a SCIM token name. | |||
Contributor
There was a problem hiding this comment.
don't forget to add it to the changelog in confluence :)
Comment on lines
-210
to
-211
| type SpecialisedAPIRoutes v SparAPITag = SparAPI | ||
| serviceSwagger = toOpenApi (Proxy @SparAPI) |
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d