Skip to content

[WPB-10314] validate swagger: fix more errors#4303

Closed
fisx wants to merge 20 commits intodevelopfrom
WPB-10314-validate-swagger-3
Closed

[WPB-10314] validate swagger: fix more errors#4303
fisx wants to merge 20 commits intodevelopfrom
WPB-10314-validate-swagger-3

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Oct 22, 2024

disambiguate paths:

PUT /users/:uid/email => PUT /users/uid/:uid/email
GET /users/:uid/rich-profile => GET /users/uid/:uid/rich-profile
[TODO: ...]

(without these, which route is selected depends on the order in which they are matched, eg. /users/handle could be stolen by /users/{uid}.)

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 22, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 22, 2024
@pcapriotti
Copy link
Contributor

Closing this in favour of #4302

@pcapriotti pcapriotti closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants