Merged
Conversation
zebot
added
the
ok-to-test
supersven
reviewed
Oct 7, 2024
| # Usage: make c package=brig test=1 | ||
| .PHONY: c | ||
| c: treefmt | ||
| c: treefmt c-fast |
Contributor
There was a problem hiding this comment.
Now that I see this, I'm wondering if our approach to squeeze everything into one makefile target fits to the idea of make. I.e. if someone wants to compile and format in one go, why don't they call e.g. make c format? 🤔
(I'm fine with your change though, because your intention probably was to keep the dev's interface stable.)
supersven
reviewed
Oct 7, 2024
| -- | 'microseconds' determines how long one unit lasts. there is a trade-off of fast | ||
| -- vs. robust in this whole setup. this type is supposed to help us find a good sweet spot. | ||
| -- | ||
| -- there is also `Milliseconds` (with small `s` after `Milli`) in "Data.Misc". maybe this |
Contributor
There was a problem hiding this comment.
Suggested change
| -- there is also `Milliseconds` (with small `s` after `Milli`) in "Data.Misc". maybe this | |
| -- there is also `Milliseconds` (with small `s` after `Milli`) in "Data.Misc". Maybe this |
supersven
reviewed
Oct 7, 2024
supersven
approved these changes
Oct 7, 2024
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
fisx
added
echoes: technical-roadmap/technical-debt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
make cvariant without treefmt; rm stack files; source comments with cross-references to redundant code.(This PR has no ticket because it takes longer to author one than to just do this.)
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d