Skip to content

[WPB-11101] Refactor invitation store#4280

Merged
mdimjasevic merged 5 commits intodevelopfrom
wpb-11101/refactor-team-invitation-store
Oct 2, 2024
Merged

[WPB-11101] Refactor invitation store#4280
mdimjasevic merged 5 commits intodevelopfrom
wpb-11101/refactor-team-invitation-store

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Oct 2, 2024

This PR improves abstraction over DB interaction relating to team invitations. An internal type is not exposed anymore and some effect actions are updated as a result.

Tracked by https://wearezeta.atlassian.net/browse/WPB-11101.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes/initiative: personal-users-to-team-users... labels Oct 2, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 2, 2024
@mdimjasevic mdimjasevic force-pushed the wpb-11101/refactor-team-invitation-store branch from ef21978 to 1fbeb65 Compare October 2, 2024 09:30
@mdimjasevic mdimjasevic force-pushed the wpb-11101/refactor-team-invitation-store branch 2 times, most recently from ff9c037 to 2e162c7 Compare October 2, 2024 12:13
@mdimjasevic mdimjasevic force-pushed the wpb-11101/refactor-team-invitation-store branch from 2e162c7 to 5f98a00 Compare October 2, 2024 12:14
@mdimjasevic mdimjasevic changed the title [WPB-11101] Refactor team invitation store [WPB-11101] Refactor invitation code store Oct 2, 2024
@mdimjasevic mdimjasevic changed the title [WPB-11101] Refactor invitation code store [WPB-11101] Refactor invitation store Oct 2, 2024
@mdimjasevic mdimjasevic marked this pull request as ready for review October 2, 2024 12:32
@mdimjasevic mdimjasevic force-pushed the wpb-11101/refactor-team-invitation-store branch from 1cce122 to 9800871 Compare October 2, 2024 12:33
@mdimjasevic mdimjasevic force-pushed the wpb-11101/refactor-team-invitation-store branch from 9800871 to 351defd Compare October 2, 2024 12:59
{-# LANGUAGE TemplateHaskell #-}

module Wire.InvitationCodeStore where
module Wire.InvitationStore where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The store is not about codes, hence the name shouldn't have "code" in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes/initiative: personal-users-to-team-users... echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants