Skip to content

[WPB-11386] Introduce length-preserving function mapRange to replace fmap. #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
battermann merged 5 commits into from
Oct 2, 2024
Merged

[WPB-11386] Introduce length-preserving function mapRange to replace fmap. #4279

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db92d9a
Introduce length-preserving function mapRange to replace fmap.
fisx Oct 1, 2024
8731409
hi ci
fisx Oct 2, 2024
77acdd4
Limit mapRange to lists.
fisx Oct 2, 2024
dcb9210
...
fisx Oct 2, 2024
8242120
...
fisx Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/3-bug-fixes/WPB-11386-map-range
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Introduce length-preserving function mapRange to replace Functor instance for Range data type.
6 changes: 5 additions & 1 deletion libs/types-common/src/Data/Range.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
module Data.Range
( Range,
toRange,
mapRange,
Within,
Bounds (..),
checked,
Expand Down Expand Up @@ -98,7 +99,10 @@ import Test.QuickCheck qualified as QC
newtype Range (n :: Nat) (m :: Nat) a = Range
{ fromRange :: a
}
deriving (Eq, Ord, Show, Functor)
deriving (Eq, Ord, Show)

mapRange :: (Functor f) => (a -> b) -> Range (n :: Nat) (m :: Nat) (f a) -> Range (n :: Nat) (m :: Nat) (f b)
mapRange f (Range as) = Range (f <$> as)
Comment thread
fisx marked this conversation as resolved.
Outdated

toRange :: (n <= x, x <= m, KnownNat x, Num a) => Proxy x -> Range n m a
toRange = Range . fromIntegral . natVal
Expand Down
2 changes: 1 addition & 1 deletion services/brig/src/Brig/IO/Intra.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ notifyUserDeletionRemotes deleted = do
pure ()
Just rangedUcs -> do
luidDeleted <- qualifyLocal' deleted
embed $ notifyUserDeleted luidDeleted (qualifyAs ucs ((fmap (fmap (qUnqualified . ucTo))) rangedUcs))
embed $ notifyUserDeleted luidDeleted (qualifyAs ucs (mapRange (qUnqualified . ucTo) rangedUcs))
-- also sent connection cancelled events to the connections that are pending
let remotePendingConnections = qualifyAs ucs <$> filter ((==) Sent . ucStatus) (fromRange rangedUcs)
forM_ remotePendingConnections $ sendCancelledEvent luidDeleted
Expand Down