[WPB-10659] Test notifications for personal user to team user migration#4268
Merged
akshaymankar merged 7 commits intodevelopfrom Sep 26, 2024
Merged
Conversation
… user joins the team
akshaymankar
force-pushed
the
WPB-10659-notify-team-members-of-joining-contacts
branch
from
9d85537 to
575b0c5
Compare
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
WPB-10659-notify-team-members-of-joining-contacts
branch
from
575b0c5 to
fb6c288
Compare
akshaymankar
changed the title
fisx
commented
Sep 26, 2024
Contributor
Author
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
can't formally approve as it's my PR, but 👍 
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
akshaymankar
approved these changes
Sep 26, 2024
akshaymankar
deleted the
WPB-10659-notify-team-members-of-joining-contacts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also contains small changes to the integration test suite:
"notifications.-1"will get the last notification.AssertionFailure. (I (@akshaymankar) wasn't aware it was appended to message earlier and implemented a separate one, then realized it was the case, so I removed appending to message part).Checklist
changelog.d