Skip to content

WPB-11101 remove invitation tables from brig#4263

Merged
fisx merged 2 commits intodevelopfrom
WPB-11101-rework-how-invitations-are-handled
Sep 24, 2024
Merged

WPB-11101 remove invitation tables from brig#4263
fisx merged 2 commits intodevelopfrom
WPB-11101-rework-how-invitations-are-handled

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Sep 23, 2024

https://wearezeta.atlassian.net/browse/WPB-11101

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes/initiative: personal-users-to-team-users... labels Sep 23, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 23, 2024
@battermann battermann marked this pull request as ready for review September 23, 2024 10:28
AND speculative_retry = '99PERCENTILE';
CREATE INDEX conn_status ON brig_test.connection (status);

CREATE TABLE brig_test.password_reset (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this one? 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK the diff looks very confusing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason the order is not stable. but it's auto-generated and tested, so you don't need to read it.

@stefanwire
Copy link
Contributor

Don’t delete columns that are still used by versions that are deployed. If you delete columns then the old version will fail in the deployment process. Rather than deleting keep the unused columns around and comment them as being discontinued in the schema migration code.

https://docs.wire.com/developer/developer/pr-guidelines.html#schema-migrations

@battermann
Copy link
Contributor Author

Don’t delete columns that are still used by versions that are deployed. If you delete columns then the old version will fail in the deployment process. Rather than deleting keep the unused columns around and comment them as being discontinued in the schema migration code.

https://docs.wire.com/developer/developer/pr-guidelines.html#schema-migrations

These tables are not used anywhere in our code

@fisx fisx merged commit 713a386 into develop Sep 24, 2024
@fisx fisx deleted the WPB-11101-rework-how-invitations-are-handled branch September 24, 2024 10:16
@fisx
Copy link
Contributor

fisx commented Sep 24, 2024

Don’t delete columns that are still used by versions that are deployed. If you delete columns then the old version will fail in the deployment process. Rather than deleting keep the unused columns around and comment them as being discontinued in the schema migration code.

https://docs.wire.com/developer/developer/pr-guidelines.html#schema-migrations

we're aware, but in this case we do not use the tables in any version, so all instances no older than the introduction of v0 should be fine.

@fisx
Copy link
Contributor

fisx commented Sep 24, 2024

@smatting sorry, didn't see your objection, let me know if you want this to be reverted on develop.

but i think we're fine...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes/initiative: personal-users-to-team-users... echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants