Conversation
Base automatically changed from
WPB-1228-servantify-gundeck-internal-api
to
develop
September 18, 2024 13:23
5094de7 to
8a1446a
Compare
8a1446a to
768a61a
Compare
c7d3973 to
188e799
Compare
188e799 to
63c1fd5
Compare
8580e4d to
d59106e
Compare
Some golden tests were missing at a time when we changed serialization from aeson to schema-profunctor. In order to make sure this didn't break anything, you can take the changes in this commit, copy them into a working-copy based on develop (ideally right this PR), and run golden tests there. The only changes are Nothing-fields that schema-profunctor translates to `"k": null`, whereas aeson (or "Data.Json.Util"?) omits the field altogether.
This reverts commit 5c76642.
Contributor
|
in in |
Contributor
|
i paused this. give it the |
fisx
approved these changes
Sep 30, 2024
Contributor
fisx
left a comment
There was a problem hiding this comment.
I think this can ship, but I'd prefer to have a nod from you @pcapriotti?
Contributor
unpauseed. |
Contributor
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-11177
make crand direct your browser to http://localhost:8080/api-internal/swagger-ui/gundeck.also

8-)) (this is before i added golden test stuff to wire-api)
Checklist
changelog.dinternalEndpointsSwaggerDocsAPI.