Work around legacy integration test resource leak.#4244
Merged
Conversation
zebot
added
the
ok-to-test
fisx
force-pushed
the
fisx/work-around-legacy-integration-test-resource-leak
branch
from
fd4c26e to
7c9b16e
Compare
pcapriotti
reviewed
Sep 18, 2024
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Shouldn't we find the resource leak instead of patching it like this?
pcapriotti
approved these changes
Sep 18, 2024
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
I guess this is fine, since these tests are legacy and maybe they will go away at some point.
fisx
force-pushed
the
fisx/work-around-legacy-integration-test-resource-leak
branch
from
022a333 to
2b95d6d
Compare
fisx
deleted the
fisx/work-around-legacy-integration-test-resource-leak
branch
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
fisx
added a commit
that referenced
this pull request
Oct 9, 2024
This reverts commit a72c70a. (it turns out this only helps with resource consumption because after running the first bach of tests, defaultMainWithIngredients exits... m|
fisx
added a commit
that referenced
this pull request
Oct 9, 2024
This reverts commit a72c70a. (it turns out this only helps with resource consumption because after running the first bach of tests, defaultMainWithIngredients exits... m|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d