Conversation
zebot
added
the
ok-to-test
elland
force-pushed
the
elland/saml-email
branch
from
79f152a to
1a6ca21
Compare
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
elland
force-pushed
the
elland/saml-email
branch
from
5048386 to
cd83f4d
Compare
elland
changed the title
emails field in SCIM user record
elland
changed the title
elland
force-pushed
the
elland/saml-email
branch
from
45a6751 to
063caf0
Compare
mdimjasevic
reviewed
Aug 19, 2024
mdimjasevic
reviewed
Aug 19, 2024
libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/Email_user.hs
Outdated
Show resolved
Hide resolved
mdimjasevic
reviewed
Aug 19, 2024
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
There's a lot of diff in golden tests. They pretty much all seem to be facing the same issue: a change in the string value where no change was needed, at least that's my hunch (e.g., replacing Email {emailLocal = "OR\32966c", emailDomain = "\RS\ENQr"} with unsafeEmailAddress "some" "example". If it's the case that the former is not a valid email address, then I can see how the change is justified, but please confirm.
libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/Invitation_team.hs
Show resolved
Hide resolved
libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/NewUserPublic_user.hs
Show resolved
Hide resolved
mdimjasevic
reviewed
Aug 19, 2024
mdimjasevic
reviewed
Aug 19, 2024
mdimjasevic
approved these changes
Aug 19, 2024
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Assuming you fix the two remaining TODOs, this is good to go.
In Spar.Scim.User you still have this comment:
TODO(elland): verify with fisx if this still applies.
And another one:
TODO: validate fallback emails?
elland
force-pushed
the
elland/saml-email
branch
from
3b6d5dd to
68a03de
Compare
stefanwire
reviewed
Aug 20, 2024
elland
force-pushed
the
elland/saml-email
branch
from
f4a06a3 to
73161b1
Compare
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This factors out one of our email types in favour of a validated email, this means a lot of tests that created arbitrary bytestrings became invalid and were replaced with simple valid emails, this might have caused redundancy in some of the golden tests.
https://wearezeta.atlassian.net/browse/WPB-665
Checklist
changelog.d