charts/{brig,galley}: Allow setting a preStop hook for the deployments#4200
Merged
akshaymankar merged 3 commits intodevelopfrom Aug 13, 2024
Merged
charts/{brig,galley}: Allow setting a preStop hook for the deployments#4200akshaymankar merged 3 commits intodevelopfrom
akshaymankar merged 3 commits intodevelopfrom
Conversation
echoes-hq
bot
added
the
echoes: technical-roadmap/throughput
zebot
added
the
ok-to-test
Member
Author
|
The idea is that we'll deploy profiling builds and set this value to upload the profile data somewhere. This was when k8s decides to kill the container, the profile data won't get lost. |
lwille
requested changes
Aug 12, 2024
Contributor
lwille
left a comment
lwille
left a comment
There was a problem hiding this comment.
just found two tiny issues
Co-authored-by: Leonhardt Wille <lwille@users.noreply.github.com>
lwille
approved these changes
Aug 12, 2024
Contributor
|
feel free to merge once CI is green :) |
This was referenced Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-9075
Checklist
changelog.d