Skip to content

Feature flag refactoring (part 2)#4193

Merged
pcapriotti merged 7 commits intodevelopfrom
pcapriotti/feature-refactoring-2
Aug 13, 2024
Merged

Feature flag refactoring (part 2)#4193
pcapriotti merged 7 commits intodevelopfrom
pcapriotti/feature-refactoring-2

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Aug 8, 2024

Follow-up to #4181.

This PR reorganises and simplifies the servant endpoints related to features.

https://wearezeta.atlassian.net/browse/WPB-10323

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/feature-refactoring August 8, 2024 07:32
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 8, 2024
@pcapriotti pcapriotti force-pushed the pcapriotti/feature-refactoring-2 branch from 0c1c284 to abbb2bb Compare August 8, 2024 07:46
@pcapriotti pcapriotti force-pushed the pcapriotti/feature-refactoring branch from 0bf9e91 to 1fa5fe1 Compare August 8, 2024 07:54
@pcapriotti pcapriotti force-pushed the pcapriotti/feature-refactoring-2 branch from abbb2bb to 3fbe923 Compare August 8, 2024 09:05
@pcapriotti pcapriotti force-pushed the pcapriotti/feature-refactoring branch from 1fa5fe1 to ca74ec3 Compare August 9, 2024 07:24
@pcapriotti pcapriotti force-pushed the pcapriotti/feature-refactoring-2 branch 2 times, most recently from 31c2fdc to 995cfe8 Compare August 9, 2024 13:16
@pcapriotti pcapriotti marked this pull request as ready for review August 12, 2024 05:40
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this fix at some point already, but it got discarded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some documentation to ::>?

Copy link
Contributor

@MangoIV MangoIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this fix at some point already, but it got discarded.

Base automatically changed from pcapriotti/feature-refactoring to develop August 12, 2024 08:45
@pcapriotti pcapriotti force-pushed the pcapriotti/feature-refactoring-2 branch from 7bea7fc to a96cdd5 Compare August 12, 2024 12:49
@pcapriotti pcapriotti merged commit 54f30dc into develop Aug 13, 2024
@pcapriotti pcapriotti deleted the pcapriotti/feature-refactoring-2 branch August 13, 2024 06:50
@echoes-hq echoes-hq bot added echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants