[feat] bump nixpkgs - allow cabal-install 3.12#4183
Conversation
zebot
added
the
ok-to-test
MangoIV
force-pushed
the
mangoiv/nixpkgs-bump
branch
5 times, most recently
from
b0ede9b to
192e5d6
Compare
MangoIV
force-pushed
the
mangoiv/nixpkgs-bump
branch
from
192e5d6 to
5a73cb3
Compare
| setup-depends: | ||
| , base | ||
| , Cabal | ||
| , Cabal >=3.12 |
There was a problem hiding this comment.
Why is this constraint needed?
There was a problem hiding this comment.
because otherwise cabal multi-repl doesn't work.
There was a problem hiding this comment.
should I put a note there?
There was a problem hiding this comment.
Isn't there only one version of Cabal available in the nix env? The project as is doesn't depend on cabal multi-repl right?
There was a problem hiding this comment.
in theory yes, in practice no, Cabal is a boot library and hence belongs to the GHC, hence nixpkgs installs two versions, 3.12 and 3.10 (which comes with GHC and cannot be removed), that then leads to proto-lens tool to select the wrong (old) version because it is actually constrained to Cabal <3.12 for no particular reason. It's all a bit messed up, if we had purely nixpkgs deps, then this wouldn't cause any issues because cabal doesn't actually care about how these deps have been installed...
There was a problem hiding this comment.
This is the reason why cabal multi-repl is not enabled by default in HLS. By fixing this for us though, it removes the bug wrt duplicate constraints and it also improves HLS because of multi-repl. I think adding this constraint (which is provisioned by the nix env anyway) is worth this improvement.
MangoIV
force-pushed
the
mangoiv/nixpkgs-bump
branch
from
82bd268 to
e9e5d20
Compare
|
I think this is ready! <3 |
MangoIV
force-pushed
the
mangoiv/nixpkgs-bump
branch
from
2e3db35 to
88fdf5a
Compare
|
|
||
| .PHONY: treefmt | ||
| treefmt: | ||
| treefmt |
There was a problem hiding this comment.
This is because treefmt was very chatty about files it's not allowed to format
| docsPkgs = [ | ||
| pkgs.plantuml | ||
| pkgs.texlive.combined.scheme-full | ||
| (pkgs.python3.withPackages |
There was a problem hiding this comment.
this is because nixpkgs not too long ago bumped the default python version and now many python packages are broken
echoes-hq
bot
added
the
echoes: technical-roadmap/throughput
3 participants
Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d