Skip to content

Simplify user feature logic#4178

Merged
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/user-features
Aug 7, 2024
Merged

Simplify user feature logic#4178
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/user-features

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Aug 1, 2024

This is a refactoring of the user feature lookup logic. It removes a redundant team lookup and a gratuitous CPS.

Followup to #4164.

https://wearezeta.atlassian.net/browse/WPB-10323

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 1, 2024
@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/one-to-one-sft August 1, 2024 07:24
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 1, 2024
@pcapriotti pcapriotti marked this pull request as ready for review August 1, 2024 07:29
@pcapriotti pcapriotti force-pushed the pcapriotti/one-to-one-sft branch from 84e0e0a to 8eda399 Compare August 1, 2024 09:01
@pcapriotti pcapriotti force-pushed the pcapriotti/user-features branch from bc45d30 to 5030c22 Compare August 1, 2024 11:29
Base automatically changed from pcapriotti/one-to-one-sft to develop August 5, 2024 11:48
@pcapriotti pcapriotti force-pushed the pcapriotti/user-features branch from 5030c22 to 0d7768d Compare August 6, 2024 12:20
@MangoIV MangoIV force-pushed the pcapriotti/user-features branch from 0d7768d to 7c5ee3c Compare August 7, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants