Skip to content

[chore] Weed out dead code.#4170

Merged
fisx merged 26 commits intodevelopfrom
elland/weed
Jul 25, 2024
Merged

[chore] Weed out dead code.#4170
fisx merged 26 commits intodevelopfrom
elland/weed

Conversation

@elland
Copy link
Contributor

@elland elland commented Jul 25, 2024

https://wearezeta.atlassian.net/browse/WPB-9742

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 25, 2024
@elland elland requested a review from fisx July 25, 2024 10:44
@elland elland marked this pull request as ready for review July 25, 2024 10:44
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first third of the review, 67 files to go!

Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

71/97 files done

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved under the condition that all my comments have been considered.

@fisx fisx merged commit d157ffb into develop Jul 25, 2024
@fisx fisx deleted the elland/weed branch July 25, 2024 21:00
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants